Overwrite pr 2 #747
Open
Overwrite pr 2 #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The new test is broken on a line I didn't change. I don't understand why this is broken, it works locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrite the pr and add a test.
If the replacement seems to work it can broke the rendered pdf.
For exemple the unit test try to replace
MAIN HEADINGperreplacementin the test pdf2-Page-PDF_1_4.pdf.
This result in this new pdf test.pdf where we can see that the text is correctly replaced but it appears to be crushed. Unfortunately I don't know too much pdf format to understand what happens here