Fix PHP Notice Processing Font GPOS OTL Data #1967
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notice occurred when loading mPDF with the commercially-licensed Myriad Pro TTF font file. Because it isn't an open-source font, and I don't have another font that exhibits this behaviour, I haven't written a unit test for it.
If you have access to the font, the following snippet will generate the PHP notice when the font cache is being created (delete the font cache afterward to replicate consecutively):
The underlying issue was when reading the font's GPOS FeatureList table. In the case of Myriad Pro, it includes the "Size" feature, but has no data associated with it. mPDF expects all features to have associated data in the form of a LookUpListIndex, even though a features LookUpCount can be zero.
I gather this font supported "Size" in the past, but it was replaced by the STAT table and the feature key was never fully removed.