-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "Undefined offset" notice in _applyGSUBrulesIndic() #1561
base: development
Are you sure you want to change the base?
Conversation
src/Otl.php
Outdated
@@ -1539,6 +1539,9 @@ function _applyGSUBrulesIndic($usetags, $scriptTag, $langsys, $is_old_spec) | |||
continue; | |||
} | |||
|
|||
if ($ptr + 1 == count($this->OTLdata)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use strict comparison here, no reason not to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use strict comparison here, no reason not to.
I have modified that.
Thanks for the PR. Please add a test case reproducing your change. Can you also please explain the change a bit? |
d572634
to
b675f02
Compare
Do I need create a issue for the test? |
Just amend the test case to this PR. See tests/Issues dir for reference |
b675f02
to
ae5879a
Compare
I have added the unit test file. Do I need do anything eles? |
ae5879a
to
1d545c7
Compare
1d545c7
to
b052cc8
Compare
Look at this please. Thanks |
reproduce this bug