Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix svg image href check #1384

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix svg image href check #1384

wants to merge 2 commits into from
+27 −2

Conversation

pedrodim
Copy link

Closes #1382

Fixed the check for var in xlink:href's path and removed the assignment to GetFullPath result (it doesn't return, so it was always null).

@Klap-in
Copy link
Contributor

Klap-in commented Feb 15, 2021 •
edited

Could you add an unit test to ensure it will not reappear in the future?
See for examples: https://github.com/mpdf/mpdf/tree/development/tests/Issues
SVG specific https://github.com/mpdf/mpdf/blob/development/tests/Mpdf/Image/SvgTest.php
But maybe a general one is more practical.

@pedrodim
Copy link
Author

@Klap-in I added a test, let me know if it's okay

@vittominacori
Copy link

@Klap-in any update about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/fix research needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG image xlink:href curl url malformed
4 participants
@pedrodim @Klap-in @vittominacori @finwe