Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning char form if needed. #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tahirrafiqueasad
Copy link

Your work is very impressive and work best for the Urdu language.

I am working on a project in which I have to know the character form. You found character form in you code but there is no specific function to get it. I added one more argument to reshape function. This argument will allow to get character form if needed.

@mpcabd
Copy link
Owner

mpcabd commented Mar 8, 2022

Thanks Tahir.

I don't really see the use case, nor do I agree with the implementation - i.e. the extra argument that would change the return type -. Please explain the use case in more detail, and let's think about a better interface implementation to solve the case.

@tahirrafiqueasad
Copy link
Author

tahirrafiqueasad commented Mar 9, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants