Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Audio extract -- extract audo clip to MP3 file while playing media file #198

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

kashwy
Copy link

@kashwy kashwy commented Dec 1, 2017

when playing a media file, user can click "Grab Audio" from the context menu by right click the mouse(the menu item will be checked), then the player will start to record audio as MP3 file to the personal music folder, until user unchecked the menu item or the media file stopped playing.
If the menu item has been checked before playing, the when a media file begin to play, the audio will be recorded automatically.
@kasper93

@@ -159,7 +159,8 @@ bool IsAudioWaveRenderer(IBaseFilter* pBF)
clsid == __uuidof(CNullAudioRenderer) ||
clsid == __uuidof(CNullUAudioRenderer) ||
clsid == CLSID_SANEAR_INTERNAL ||
clsid == CLSID_SANEAR;
clsid == CLSID_SANEAR ||
clsid == CLSID_InfTee; // allow the inftee to be connected from Audio Switch , 171003
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent indent

@kasper93
Copy link
Contributor

kasper93 commented Jan 6, 2018

What are the purpose of this functionality? There are better ways to extract audio form medial file. But I can see this useful as quick grab for audio part quickly without any other software.

I might be missing the point, because I'm not sure how exactly this functionality needs to be used. But first thing that comes to mind is to separate whole filter and compression from player. It will be more flexible to have external filter that does dirty job and just have integration code in the player to request recording (filter connection etc.).

Frankly I think the good place for such functionality would be audio decoder which have access to original stream which would allow to skip recompression in some cases.

@kashwy
Copy link
Author

kashwy commented Jan 9, 2018

@kasper93
Advantages of this feature:

  1. Video courses from online educational websites such as Coursera can be quickly converted to an MP3 version, which can be imported into an MP3 player, allowing for quick and portable review of lecture material while walking,driving or in transit. The user is able to convert the video into MP3 while they are watching the video, and does not need an extra step, saving time.

  2. Ease of obtaining an MP3 copy of a music video WHILE watching it, without the need to look for another tool. After the user finishes watching the video, the MP3 file is already generated.

Using audio decoder for this task requires various formats of the source. Our solution handles any file format.
Re-compression is needed for users who wish to use different MP3 bit rate.
We included an options page just like in our last commit.
We need to process this in the player because the player is more powerful than the external filter. This provides easier buffer and thread handling, etc.

Please consider the changes,
Thanks.

@chros73
Copy link

chros73 commented Jan 22, 2018

Hi! Take a look at this comment ...

the  compiled Binary  for download
stdedos pushed a commit to stdedos/mpc-hc that referenced this pull request Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants