Audio extract -- extract audo clip to MP3 file while playing media file #198
base: develop
Are you sure you want to change the base?
Conversation
src/DSUtil/DSUtil.cpp
Outdated
@@ -159,7 +159,8 @@ bool IsAudioWaveRenderer(IBaseFilter* pBF) | |||
clsid == __uuidof(CNullAudioRenderer) || | |||
clsid == __uuidof(CNullUAudioRenderer) || | |||
clsid == CLSID_SANEAR_INTERNAL || | |||
clsid == CLSID_SANEAR; | |||
clsid == CLSID_SANEAR || | |||
clsid == CLSID_InfTee; // allow the inftee to be connected from Audio Switch , 171003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent indent
What are the purpose of this functionality? There are better ways to extract audio form medial file. But I can see this useful as quick grab for audio part quickly without any other software. I might be missing the point, because I'm not sure how exactly this functionality needs to be used. But first thing that comes to mind is to separate whole filter and compression from player. It will be more flexible to have external filter that does dirty job and just have integration code in the player to request recording (filter connection etc.). Frankly I think the good place for such functionality would be audio decoder which have access to original stream which would allow to skip recompression in some cases. |
@kasper93
Using audio decoder for this task requires various formats of the source. Our solution handles any file format. Please consider the changes, |
Hi! Take a look at this comment ... |
the compiled Binary for download
when playing a media file, user can click "Grab Audio" from the context menu by right click the mouse(the menu item will be checked), then the player will start to record audio as MP3 file to the personal music folder, until user unchecked the menu item or the media file stopped playing.
If the menu item has been checked before playing, the when a media file begin to play, the audio will be recorded automatically.
@kasper93