Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Kochava to v8 and remove Cocoapods #24

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

This updates to the latest version of the Kochava SDK which includes a privacy manifest and optional removal of user tracking. When they did the version bump from 7 to 8, they changed github repo names, SPM package names, some class/method names, but the actual functionality is the same.

Kochava's SDK, as of version 8.0.0, no longer supports CocoaPods. As this version is the minimum required for App Store submission due to the iOS 17 privacy manifest changes, the mParticle Kochava Kit by association no longer supports CocoaPods either so I've removed the podspec and removed pushing to CocoaPods from the release CI action and release script. I added a VERSION file so there's something to update for the CI release version bump commit as there is no longer a podfile to update.

Due to the optional removal of tracking functionality, we now have two SPM targets: mParticle-Kochava and mParticle-Kochava-NoTracking

The mParticle-Kochava retains all of the same functionality of the previous version of Kochava, while the mParticle-Kochava-NoTracking removes the parts that Apple defines as "tracking".

Specifically this means, mParticle-Kochava depends on the KochavaNetworking, KochavaMeasurement, and KochavaTracking packages, while the mParticle-Kochava-NoTracking target only depends on the KochavaNetworking and KochavaMeasurement packages.

Testing Plan

  • Was this tested locally? If not, explain why.
  • E2E tested both build targets (normal and no tracking)
  • Tested release.sh changes by running it manually

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit cb875ad into development Apr 26, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/6360-update-kochava-v8 branch April 26, 2024 20:08
mparticle-automation added a commit that referenced this pull request Apr 26, 2024
# [8.5.0](v8.4.0...v8.5.0) (2024-04-26)

### Features

* Update Kochava to v8 and remove Cocoapods ([#24](#24)) ([cb875ad](cb875ad))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants