Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Django to 4.2.13 #7811

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

EvaBardou
Copy link
Collaborator

@EvaBardou EvaBardou commented Sep 19, 2023

Depends on #7814

Closes #7794

Three code updates were needed for this bump, see Django 4.2 release notes for all changes:


I've tested the bump locally by exporting:

export DATABASE_URL=psql://postgres:mozilla1234@postgres:5432/treeherder

to use the postgres database instead of the mysql one.

And running:

docker-compose up --build

@EvaBardou EvaBardou marked this pull request as draft September 19, 2023 13:48
@EvaBardou EvaBardou marked this pull request as ready for review September 19, 2023 14:29
@EvaBardou EvaBardou requested a review from a team as a code owner September 19, 2023 14:29
@EvaBardou EvaBardou marked this pull request as draft September 20, 2023 08:34
@EvaBardou
Copy link
Collaborator Author

I need to submit a new PR removing mysql before we merge this one.

@EvaBardou EvaBardou force-pushed the bump-django-4.2 branch 3 times, most recently from 6a72be9 to e5d7315 Compare May 13, 2024 16:32
@EvaBardou EvaBardou changed the title Bump Django to 4.2.5 Bump Django to 4.2.13 May 13, 2024
@EvaBardou EvaBardou marked this pull request as ready for review May 30, 2024 13:34
@EvaBardou
Copy link
Collaborator Author

@Archaeopteryx Since #7814 was just merged, I've rebased this PR on master, it is ready for review. 😄

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.36%. Comparing base (494ca3c) to head (6089a69).

Files Patch % Lines
treeherder/perf/models.py 70.00% 3 Missing ⚠️
treeherder/model/models.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7811       +/-   ##
===========================================
+ Coverage   58.56%   90.36%   +31.79%     
===========================================
  Files         239      308       +69     
  Lines       11262    15719     +4457     
  Branches     3385        0     -3385     
===========================================
+ Hits         6596    14204     +7608     
+ Misses       4504     1515     -2989     
+ Partials      162        0      -162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archaeopteryx Archaeopteryx merged commit e7dc8f1 into mozilla:master May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants