Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1887995 - Add relay_backend app #720

Merged
merged 7 commits into from May 9, 2024
Merged

Bug 1887995 - Add relay_backend app #720

merged 7 commits into from May 9, 2024

Conversation

akkomar
Copy link
Contributor

@akkomar akkomar commented Apr 2, 2024 •
edited

Tested with:

python -m probe_scraper.runner --glean --glean-repo glean-server --glean-repo relay-backend --dry-run

Which returned:

Getting commits for repository glean-server
Cloning https://github.com/mozilla/glean_parser into /var/folders/tj/6t1b0gmd50z6w50b3fn825fm0000gn/T/tmp74ttd2b0/mozilla/glean_parser.git
  Got 2 commits
Getting commits for repository relay-backend
Cloning https://github.com/mozilla/fx-private-relay into /var/folders/tj/6t1b0gmd50z6w50b3fn825fm0000gn/T/tmp74ttd2b0/mozilla/fx-private-relay.git
  Got 1 commits

jwhitlock
jwhitlock reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like too much was copied from the Firefox Accounts Backend entry.

repositories.yaml Outdated Show resolved Hide resolved
repositories.yaml Outdated Show resolved Hide resolved
akkomar
akkomar commented May 9, 2024
View reviewed changes
probe_scraper/scrapers/git_scraper.py
@@ -41,6 +41,7 @@
"mozilla-vpn-android": "2021-05-25 00:00:00",
"rally-markup-fb-pixel-hunt": "2021-12-04 00:00:00",
"rally-citp-search-engine-usage": "2022-04-15 00:00:00",
"relay-backend": "2024-05-09 00:00:00",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because some of the earlier commits threw an error during a dry-run:

    Body: Error in processing commit f5beadd3e5552dfe29c57abd1b7a7318675e8840
    Body: Error in processing commit 69c650916cd2a2a4f04af6c98f1280e7a6c676ec
    Body: Error in processing commit 9f3c33cd21545a9151c55132afee8a981bb698c2
    Body: Error in processing commit 899f2fd59277dc38376de03000e1e51f95c3ae2c
    Body: Error in processing commit 700454a838a476c342cb0fd45b41f00eba0cfeb9
    Body: Error in processing commit ab2f13d258eba140aeb30af0714cac036cce6556

@akkomar akkomar marked this pull request as ready for review May 9, 2024 16:42
@travis79
Copy link
Member

travis79 commented May 9, 2024

Did this pass with a dry-run?

@akkomar
Copy link
Contributor Author

akkomar commented May 9, 2024

Did this pass with a dry-run?

Yes, it succeeded. I put part of the output above.

@akkomar akkomar merged commit a0d66f2 into main May 9, 2024
2 checks passed
@akkomar akkomar deleted the relay_backend branch May 9, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhitlock jwhitlock jwhitlock left review comments

@travis79 travis79 travis79 approved these changes

@chutten chutten Awaiting requested review from chutten chutten is a code owner

@whd whd Awaiting requested review from whd whd is a code owner

@mikaeld mikaeld Awaiting requested review from mikaeld mikaeld is a code owner

@Dexterp37 Dexterp37 Awaiting requested review from Dexterp37 Dexterp37 is a code owner

@badboy badboy Awaiting requested review from badboy badboy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akkomar @travis79 @jwhitlock