Refactor code in the web/ folder to use async/await
#9995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
Snuffleupagus
force-pushed
the
async-web
branch
from
b593cf2
to
bd86e6d
Compare
…r than manually returning `Promise`s This changes the methods signatures of `GenericL10n`, `MozL10n`, and `NullL10n`.
…manually returning `Promise`s
…than manually returning `Promise`s
…ually returning `Promise`s
…rather than manually returning `Promise`s *Ignoring whitespace changes is probably necessary, in order for the diff to be readable.*
…number of Promises and temporary variables necessary when setting the initial document location
Snuffleupagus
force-pushed
the
async-web
branch
from
bd86e6d
to
1bdfdd0
Compare
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a2e401533820fb8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a2e401533820fb8/output.txt Total script time: 4.59 mins Published |
timvandermeij
approved these changes
Sep 8, 2018
|
Looks really good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from PR #9944 as requested by @brendandahl.
Much more manageable diff with https://github.com/mozilla/pdf.js/pull/9995/files?w=1