Fixed critical unhandled promise that prevented error catching using API #9689
Conversation
|
If this PR has no conflicts, even after all the changes of late, please consider merging it. It's just one line and really allows for error handling in a lot of situations where we are just stuck with no way of catching errors. We would really hope to use the main package instead of running temporary forks, so if you would venture a timeframe of implementation, that would be great. Thanks for all the hard work! Best regards, |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/782d81c0232499d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/038a23057514511/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/782d81c0232499d/output.txt Total script time: 19.21 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/038a23057514511/output.txt Total script time: 23.42 mins
Image differences available at: http://54.215.176.217:8877/038a23057514511/reftest-analyzer.html#web=eq.log |
|
Thanks for the patch! |
Fixed critical unhandled promise that prevented error catching using API
The affected line causes an unhandled rejection if any code inside _nextBound throws an error.
This makes using the API impossible, as there is no way of catching a failing PDF.
For this issue, the offending PDF and the underlying problem throwing the error, please refer to: #9675
This PR fixes the unhandled rejection error only. This is not a fix for the error that is being thrown. It's just an indispensable catch to the promise so that the error can bubble up to where it should in order for the error to be catched.