Composed an example for single page viewer in response to issue #8951 #8989
Conversation
There was a problem hiding this comment.
Once you've addressed the comments, please remember to squash the commits (https://github.com/mozilla/pdf.js/wiki/Squashing-Commits).
Edit: To more clearly see the difference between the existing pageviewer and simpleviewer examples, and the new one that you add here, you can try to locally use (but don't commit it) var DEFAULT_URL = '../../test/pdfs/issue3115r.pdf'; in the various example *.js files and compare what happens when clicking on the links in that PDF file.
|
|
||
| var container = document.getElementById('viewerContainer'); | ||
|
|
||
| // pdfLinkService not used since single page viewer |
There was a problem hiding this comment.
This isn't correct, the whole point of the PDFSinglePageViewer (as opposed to PDFPageView) is that it implements the same interface as PDFViewer (for e.g. PDF files containing links).
Basically, this new file should be an almost verbatim copy of https://github.com/mozilla/pdf.js/blob/master/examples/components/simpleviewer.js, but using PDFJS.PDFSinglePageViewer instead of PDFJS.PDFViewer and var pdfSinglePageViewer instead of var pdfViewer.
| pdfSinglePageViewer.setFindController(pdfFindController); | ||
|
|
||
| container.addEventListener('pagesinit', function () { | ||
| //Changing default scale value |
There was a problem hiding this comment.
Just keep the same format as the existing comment here, i.e. // We can use pdfSinglePageViewer now, e.g. let's change default scale.
|
Thanks for the review. |
This pull request is in response to issue #8951.
It contains a components example in the
examples/componentsfolder for single page viewer.