Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single page viewer example #8984

Closed

Conversation

de1ux
Copy link

@de1ux de1ux commented Oct 1, 2017

Single page viewer example in the same vein as SimpleViewer. Resolves #8951

@mukulmishra18
Copy link
Contributor

I think there is someone already started working on this issue, so IMO it is unethical to submit a PR. I would suggest to try some other issues also(there are quite a lot with good-begineer-bug label). Please confirm(or ask to assign the issue) in future, that someone is not working on the issue before submitting a PR. Rest I am leaving on the project members.

@timvandermeij can you please have a look on this?

@timvandermeij
Copy link
Contributor

timvandermeij commented Oct 1, 2017

Yes, next time please indicate on the issue that you're (planning to be) working on the ticket. This is done to avoid double work, because now two people worked on the exact same issue.

Code-wise this looks good at first glance, but it still needs a more in-depth review with testing.

@timvandermeij
Copy link
Contributor

Closing since the fix is already merged in #8990. Nevertheless, thank you for your looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants