Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init PDFWorker via MesssagePort. #8107

Merged
merged 1 commit into from Feb 24, 2017

Conversation

yurydelendik
Copy link
Contributor

Webpack people can use 'pdfjs-dist/webpack' module for PDF.js autoconfiguration.

Fixes #7612
Addresses #7683

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/8fc414c822c7a13/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://54.215.176.217:8877/2a48fbff731d9b0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/2a48fbff731d9b0/output.txt

Total script time: 21.72 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/8fc414c822c7a13/output.txt

Total script time: 26.55 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/640d58b5b85ad34/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/640d58b5b85ad34/output.txt

Total script time: 2.16 mins

Published

@timvandermeij timvandermeij merged commit 752510f into mozilla:master Feb 24, 2017
@timvandermeij
Copy link
Contributor

Looks good, thank you!

@timvandermeij
Copy link
Contributor

The wiki page has been updated as well.

@jwahyoung
Copy link

@timvandermeij Are there usage notes for this? I checked the wiki but I didn't find the information. Based on the source code, I think I'm supposed to manually init the worker myself and then pass it as an argument to PDFJS.workerPort, but I'm not sure. Can you verify this?

@yurydelendik yurydelendik deleted the init-via-port branch February 28, 2017 17:01
@yurydelendik
Copy link
Contributor Author

I think I'm supposed to manually init the worker myself and then pass it as an argument to PDFJS.workerPort

@jedd-ahyoung see external/dist/webpack.js for usage example with webpack -- webpack loader takes care of the worker initialization (and it's out of control of the PDF.js). You can wrap existing worker with PDFWorker object and pass it to the PDF.js.

@yurydelendik yurydelendik mentioned this pull request Jun 10, 2017
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants