Move symbolic font glyphs to private use area if they don't have unic… #7482
Conversation
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0aa2d7a49edd65e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a801092cd7ad6b1/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/a801092cd7ad6b1/output.txt Total script time: 22.78 mins
Image differences available at: http://107.22.172.223:8877/a801092cd7ad6b1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/0aa2d7a49edd65e/output.txt Total script time: 27.86 mins
Image differences available at: http://107.21.233.14:8877/0aa2d7a49edd65e/reftest-analyzer.html#web=eq.log |
| @@ -827,7 +829,7 @@ var Font = (function FontClosure() { | |||
| // with firefox and thuluthfont). | |||
| if ((usedFontCharCodes[fontCharCode] !== undefined || | |||
| isProblematicUnicodeLocation(fontCharCode) || | |||
| (isSymbolic && isIdentityUnicode)) && | |||
| (isSymbolic && (isIdentityUnicode || !hasUnicodeValue))) && | |||
There was a problem hiding this comment.
Nit: Wouldn't (isSymbolic && !hasUnicodeValue) be a sufficient condition here, given that initially hasUnicodeValue = false and that it can only become true in the !isIdentityUnicode case?
|
Closing as supseded by #7705, which is reported to have a complete solution for the issue and in which this commit is included. |
…ode mappings.