Fix issue with resizing the zoom box width - follow-up of #2816

[Snuffleupagus]

This fixes an issue with the automatic resizing of the zoom box width.
Currently, if the viewer is small enough that the zoom box isn't visible on load, the zoom box resizing doesn't work. This means that if the viewer is then enlarged, it will look like this:

This PR fixes this, so that the zoom box will only be resized on load when it's actually visible.

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/032ce762fd79697/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/032ce762fd79697/output.txt

Total script time: 0.33 mins

Published

• Viewer: http://107.22.172.223:8877/032ce762fd79697/web/viewer.html
• Extension: http://107.22.172.223:8877/032ce762fd79697/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/032ce762fd79697/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

@Snuffleupagus: that's funny, I mentioned this yesterday in another issue: #3252. Great that you've solved this; means that issue is also partly solved. :)

[Snuffleupagus]

To make it easier to maintain the code, I replaced the parameters controlling the width of the zoom box with constants placed at the top of viewer.js.
I also found that in IE and Chrome, the native drop down button isn't completely hidden currently, so this PR has been updated to fix that as well.

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7d739d47709c53c/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/7d739d47709c53c/output.txt

Total script time: 0.35 mins

Published

• Viewer: http://107.22.172.223:8877/7d739d47709c53c/web/viewer.html
• Extension: http://107.22.172.223:8877/7d739d47709c53c/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.22.172.223:8877/7d739d47709c53c/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

Using your latest preview, it has become better, but with responsive design view I get the following. This is because the text 'Automatisch zoomen' is longer than in most languages I guess. So there should be a way to take variable lengths into account... :-(

[Snuffleupagus]

@timvandermeij This PR doesn't really change anything with regards to the current resizing of the zoom box, it just fixes a small bug and refactors some of the code. So I don't really understand how this PR is to blame!?

Also, I think that I solved most of these overlap issues in my patches for #2792. That said, in the Dutch l10n the zoom box is so huge, that these changes probably won't help completely. The problem is that if we change this to work perfectly in Dutch, it would look bad in all (or almost all) other languages since it would introduce a lot of wasted space in the toolbar.
I don't speak Dutch, but would it be possible to change the translation somewhat to mitigate the issue?

Ninja edit: I just tried the latest Firefox extension from #2792, and it's almost perfect even in Dutch!
As a said previously (#2792 (comment)), I think that as long as it looks and works OK in Firefox, I personally can live with a few small issues in the web viewer.

[timvandermeij]

@Snuffleupagus: I just assumed that this was related to this PR, but that was wrong I guess. There is not really a way to make the text smaller. However, it does indeed work perfectly fine in #2792, so all issues will be resolved if both PRs land. Thank you for your explanation! :)

[yurydelendik]

thank you