Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the _fetchDocument helper function in getDocument #18091

Merged
merged 2 commits into from
May 14, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This function has been modified a number of times over the years, and at this point it's small/simple enough that we can just inline the code instead.

This function has been modified a number of times over the years, and at this point it's small/simple enough that we can just inline the code instead.
src/display/api.js Outdated Show resolved Hide resolved
This is fairly old code, and at some point the need for this to be asynchronous disappeared.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/725a0c44bb138cb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/725a0c44bb138cb/output.txt

Total script time: 1.26 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d44e32abd833363/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/256eff0d6d4cb48/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/256eff0d6d4cb48/output.txt

Total script time: 27.65 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 14
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/256eff0d6d4cb48/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d44e32abd833363/output.txt

Total script time: 43.17 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/d44e32abd833363/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 7e5e06b into mozilla:master May 14, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you for simplifying this!

@Snuffleupagus Snuffleupagus deleted the rm-_fetchDocument branch May 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants