Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-parsing global images that failed decoding (issue 18042, PR 17428 follow-up) #18047

Merged
merged 1 commit into from
May 15, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented May 4, 2024

For images that failed to decode once we want to avoid a pointless round-trip to the main-thread, which could otherwise happen for globally cached images.


Please note: Submitted as a "draft", since I'm not keen on making these changes without test-coverage.

Given the lack of a real-world PDF document, since none was provided, I've tried to manually create a broken one. However, I obviously cannot tell if it properly covers the original issue.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/680322ba53bd9ff/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b3d520195b38933/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/680322ba53bd9ff/output.txt

Total script time: 27.47 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/680322ba53bd9ff/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b3d520195b38933/output.txt

Total script time: 42.82 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 8

Image differences available at: http://54.193.163.58:8877/b3d520195b38933/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus marked this pull request as ready for review May 6, 2024 13:12
@plantago
Copy link

I tested the changes in this PR with the pdf files I was having problems with.
Everything works fine now.

@Snuffleupagus Snuffleupagus requested review from calixteman and removed request for calixteman May 14, 2024 09:19
…17428 follow-up)

For images that failed to decode once we want to avoid a pointless round-trip to the main-thread, which could otherwise happen for globally cached images.
@Snuffleupagus Snuffleupagus added the release-blocker Blocker for the upcoming release label May 14, 2024
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/728546f044e3c2b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/728546f044e3c2b/output.txt

Total script time: 1.16 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; the included PDF file seems to cover the problem well, also given that the original reporter shared that this patch solved the issue. Thanks!

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me either. Thank you for doing this.

@timvandermeij timvandermeij merged commit 4db8436 into mozilla:master May 15, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-18042 branch May 15, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering crashes if PDF contains images which cannot be decoded
5 participants