Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-minor] Move the page reference/number caching into the API #18001

Merged
merged 3 commits into from Apr 29, 2024
Merged

[api-minor] Move the page reference/number caching into the API #18001

merged 3 commits into from Apr 29, 2024
+75 −124

Commits on Apr 29, 2024

  1. Inline the helper method in PDFLinkService.goToDestination 

    We no longer need the helper method to *potentially* call itself once data is available, and can instead take full advantage of async/await by inlining the code.
    @Snuffleupagus
    Snuffleupagus committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fa69d9a View commit details
    Browse the repository at this point in the history

  2. [api-minor] Move the page reference/number caching into the API 

    Rather than having to handle this *manually* throughout the viewer, this functionality can instead be moved into the API which simplifies the code slightly.
    @Snuffleupagus
    Snuffleupagus committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f6cd039 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary check from PDFLinkService.goToDestination (PR 17… 

    …984 follow-up)

After the changes in PR 17984 this code can no longer be reached, since the destination is now validated on the worker-thread.
    @Snuffleupagus
    Snuffleupagus committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    150964d View commit details
    Browse the repository at this point in the history