Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-minor] Add the pinch-to-zoom feature (bug 1677933) #15886

Merged
merged 1 commit into from Jan 4, 2023
Merged

[api-minor] Add the pinch-to-zoom feature (bug 1677933) #15886

merged 1 commit into from Jan 4, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

Snuffleupagus
Snuffleupagus reviewed Jan 3, 2023
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Jan 3, 2023
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the pinch_to_zoom branch 2 times, most recently from 94b0eec to 57284ba Compare January 3, 2023 17:42
Snuffleupagus
Snuffleupagus reviewed Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that this doesn't interfere with the touch-handling that exists for PresentationMode?

web/app.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Jan 4, 2023
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
@Snuffleupagus Snuffleupagus linked an issue Jan 4, 2023 that may be closed by this pull request
Use more natural zooming on mobile #2582
Closed
@calixteman calixteman changed the title Add the pinch-to-zoom feature (bug 1677933) [api-minor] Add the pinch-to-zoom feature (bug 1677933) Jan 4, 2023
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Jan 4, 2023

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a1cfb7c9812045b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 4, 2023

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a1cfb7c9812045b/output.txt

Total script time: 1.28 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, since this appears to be working as far as I can tell :-)

(I don't have a computer with a touch-screen, so I used my phone for some quick testing.)

@calixteman
Copy link
Contributor Author

r=me, since this appears to be working as far as I can tell :-)

(I don't have a computer with a touch-screen, so I used my phone for some quick testing.)

I wrote the patch on a computer with a touch-screen: it works well for me.
And I tested it on my phone in using the above viewer and it worked well either.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Jan 4, 2023

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bdf62e0b4ddaf36/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 4, 2023

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6924a11e4848a69/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 4, 2023

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bdf62e0b4ddaf36/output.txt

Total script time: 4.40 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jan 4, 2023

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6924a11e4848a69/output.txt

Total script time: 13.86 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 4faf927 into mozilla:master Jan 4, 2023
@calixteman calixteman deleted the pinch_to_zoom branch January 4, 2023 16:20
@Snuffleupagus Snuffleupagus mentioned this pull request Mar 19, 2023
Merged
@3rd3 3rd3 mentioned this pull request Apr 20, 2023
Closed
@OverflowCat OverflowCat mentioned this pull request Jun 7, 2023
Closed
2 tasks
@asandikci asandikci mentioned this pull request Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use more natural zooming on mobile
3 participants
@calixteman @Snuffleupagus @pdfjsbot