Cache the "raw" standard font data in the worker-thread (PR 12726 follow-up) #13515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
standardFontDataCache
branch
2 times, most recently
from
d5bd3f6
to
11e3b7c
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/4e1c914f6aee4af/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://3.101.106.178:8877/9f44160cf612609/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4e1c914f6aee4af/output.txt Total script time: 26.13 mins
Image differences available at: http://54.67.70.0:8877/4e1c914f6aee4af/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/9f44160cf612609/output.txt Total script time: 29.22 mins
Image differences available at: http://3.101.106.178:8877/9f44160cf612609/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
standardFontDataCache
branch
2 times, most recently
from
9faaec6
to
37c0a18
Compare
…low-up) *This implementation is basically a copy of the pre-existing `builtInCMapCache` implementation.* For some, badly generated, PDF documents it's possible that we'll end up having to fetch the *same* standard font data over and over (which is obviously inefficient). While not common, it's certainly possible that a PDF document uses *custom* font names where the actual font then references one of the standard fonts; see e.g. issue 11399 for one such example. Note that I did suggest adding worker-thread caching of standard font data in PR 12726, however it wasn't deemed necessary at the time. Now that we have a real-world example that benefit from caching, I think that we should simply implement this now.
Snuffleupagus
force-pushed
the
standardFontDataCache
branch
from
37c0a18
to
a01c599
Compare
timvandermeij
approved these changes
Jun 9, 2021
|
Looks good to me; thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is basically a copy of the pre-existing
builtInCMapCacheimplementation.For some, badly generated, PDF documents it's possible that we'll end up having to fetch the same standard font data over and over (which is obviously inefficient).
While not common, it's certainly possible that a PDF document uses custom font names where the actual font then references one of the standard fonts; see e.g. issue #11399 for one such example. Edit: Loading all pages of that document currently causes the
FoxitSymbol.pfbfile to be loaded thirteen times.Note that I did suggest adding worker-thread caching of standard font data in PR #12726, however it wasn't deemed necessary at the time. Now that we have a real-world example that benefit from caching, I think that we should simply implement this now.