Update the zoom dropdown width calculation to work better in locales with long zoom-strings (PR 11077 follow-up) #12250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with long zoom-strings (PR 11077 follow-up) With the changes in PR 11077, the zoom dropdown now looks "squashed" in locales with longer than average zoom-strings[1]. The reason is that the zoom-value and the dropdown-icon are too close together, which doesn't look good in affected locales. To fix this, the following changes are made: - Increase the calculated dropdown width, in `Toolbar._adjustScaleWidth`, to account for the much wider icon (7 px -> 16 px) and the increased padding. - Move the dropdown-icon *slightly* outwards, and also *slightly* reduce the left (right in RTL locales) padding of the dropdown-contents. - Finally, remove the right (left in RTL locales) padding to reduce the chance of the *default* browser dropdown-icon being visible. --- [1] This affects e.g. the `de` and `nl` locales, but there's probably other examples as well.
Snuffleupagus
commented
Aug 20, 2020
| @@ -352,7 +352,7 @@ html[dir='rtl'] #outerContainer.sidebarOpen #viewerContainer:not(.pdfPresentatio | |||
| background-color: var(--sidebar-bg-color); | |||
| } | |||
| html[dir='ltr'] #toolbarSidebar { | |||
| box-shadow: inset -1px 0 0 rgba(0, 0, 0, 0.25), | |||
There was a problem hiding this comment.
I didn't manually change this line, but upon saving my editor removed the trailing space; given that we shouldn't have trailing spaces anywhere keeping this change thus seem OK here.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8e5599a7106f9e0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8e5599a7106f9e0/output.txt Total script time: 3.38 mins Published |
timvandermeij
approved these changes
Aug 20, 2020
|
Thank you for the follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes in PR #11077, the zoom dropdown now looks "squashed" in locales with longer than average zoom-strings[1]. The reason is that the zoom-value and the dropdown-icon are too close together, which doesn't look good in affected locales.
To fix this, the following changes are made:
Toolbar._adjustScaleWidth, to account for the much wider icon (7 px -> 16 px) and the increased padding.[1] This affects e.g. the
deandnllocales, but there's probably other examples as well.