Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI design (Change some colors) #10673

Closed
wants to merge 3 commits into from
Closed

Conversation

shge
Copy link

@shge shge commented Mar 23, 2019

Since the colors and gradations were a little outdated, I made some changes to the UI design. 馃槂

@Snuffleupagus
Copy link
Collaborator

Just making the entire default viewer, which is shipping in Firefox, essentially black really isn't an improvement at all. There's a number of issues such as e.g. the main toolbar being indistinguishable from the rest of the viewer, and generally a fairly incomplete attempt at changing the styling in any coherent way.

For a custom implementation you're obviously free to do whatever you want, but I don't think this is something that belongs in the main PDF.js library.

@shge
Copy link
Author

shge commented Mar 23, 2019

@Snuffleupagus
Okay, I will change only selection colors.

@Snuffleupagus
Copy link
Collaborator

Okay, I will change only selection colors.

That's already tracked in issue #9184, and it's not really clear if/how any changes should actually be made here (since there's a degree of subjectivity involved).
As for these particular changes, they are not an improvement since for one they make the actual text less clear when it's selected (probably caused by the change in opacity).

@timvandermeij
Copy link
Contributor

I agree with the above. The only thing we may consider is #9702, but the designers from Firefox should come up with a design first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants