Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation for a contextmenu item #2634

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Missing translation for a contextmenu item #2634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/background/assignManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
}
const site = siteConfigs[urlKey];
// In hindsight we should have stored this
// TODO file a follow up to clean the storage onLoad

Check warning on line 122 in src/js/background/assignManager.js

View workflow job for this annotation

GitHub Actions / Run tests 

Unexpected 'todo' comment: 'TODO file a follow up to clean the...'
site.hostname = urlKey.replace(/^siteContainerMap@@_/, "");
sites[urlKey] = site;
}
Expand Down Expand Up @@ -764,7 +764,7 @@
async initBookmarksMenu() {
browser.contextMenus.create({
id: this.OPEN_IN_CONTAINER,
title: "Open Bookmark in Container Tab",
title: browser.i18n.getMessage("openBookmarkInContainerTab"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do I see this string? I have the add-on installed, but don't see it in the context menu for bookmarks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In MAC preferences, you need to tick "Enable bookmark menus"

image

  1. Open Firefox sidebar and select the bookmarks view (Ctrl + B).
  2. Right-Click on a bookmark

contexts: ["bookmark"],
});

Expand Down