Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify width and height in SVG icon. #2628

Merged
merged 1 commit into from Mar 4, 2024
Merged

Explicitly specify width and height in SVG icon. #2628

merged 1 commit into from Mar 4, 2024

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 2, 2024

To work around https://bugzil.la/1883166.

Before submitting your pull request

  • I agree to license my code under the MPL 2.0 license.
  • I rebased my work on top of the main branch.
  • I ran npm test and all tests passed.
  • I added test coverages if relevant.

Description

Please include a summary of the changes including relevant motivation and context.

Type of change

Select all that apply.

  • Bug fix
  • New feature
  • Major change (fix or feature that would cause existing functionality to work differently than in the current version)

@emilio
Copy link
Contributor Author

emilio commented Mar 2, 2024

r? @dannycolin

@dannycolin dannycolin merged commit 0acc48a into mozilla:main Mar 4, 2024
2 checks passed
@emilio emilio deleted the icon-macos-fix branch March 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycolin dannycolin dannycolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilio @dannycolin