Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Remember my decision for this site" checkbox useful even when pressing deny button #2617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danjovich
Copy link

Before submitting your pull request

  • I agree to license my code under the MPL 2.0 license.
  • I rebased my work on top of the main branch.
  • I ran npm test and all tests passed.
  • I added test coverages if relevant.

Description

When you try to open an assigned site in a container to which it is not assigned, or in no container at all, the "confirm-page" shows up:

image

In this page, the "Remember my decision for this site" checkbox is only useful if you press the blue "Open in {container-name} container" button, but does nothing if you press the gray button.

This PR makes the checkbox useful for when you press the gray button, changing the site's assigned container to the one you were trying to open it in, or removing the site's assignment if you wanted to open the site in a no-container tab and checked the checkbox.

Aside from that, I fixed a bug where a nonexistent method storageArea.getByContainer was called in assignManager.js, once this was breaking my changes (this is apparently also fixed in the #2572 PR).

Type of change

Select all that apply.

  • Bug fix
  • New feature
  • Major change (fix or feature that would cause existing functionality to work differently than in the current version)

Tag issues related to this pull request:

@danjovich danjovich changed the title Make "Remember my decision for this site" checkbox useful when opening in current tab/non-assigned container Make "Remember my decision for this site" checkbox useful even when pressing deny button Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant