Make "Remember my decision for this site" checkbox useful even when pressing deny button #2617
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm test
and all tests passed.Description
When you try to open an assigned site in a container to which it is not assigned, or in no container at all, the "confirm-page" shows up:
In this page, the "Remember my decision for this site" checkbox is only useful if you press the blue "Open in {container-name} container" button, but does nothing if you press the gray button.
This PR makes the checkbox useful for when you press the gray button, changing the site's assigned container to the one you were trying to open it in, or removing the site's assignment if you wanted to open the site in a no-container tab and checked the checkbox.
Aside from that, I fixed a bug where a nonexistent method
storageArea.getByContainer
was called in assignManager.js, once this was breaking my changes (this is apparently also fixed in the #2572 PR).Type of change
Select all that apply.
Tag issues related to this pull request: