Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove seperate scanner instances #516

Merged
merged 31 commits into from
Jan 17, 2024
Merged

remove seperate scanner instances #516

merged 31 commits into from
Jan 17, 2024

Conversation

LeoMcA
Copy link
Contributor

@LeoMcA LeoMcA commented Jan 16, 2024

Highly suggest reviewing commit-by-commit, they should be atomic. See the updated README for how to get things running locally.

This PR removes the separate scanner instance, which allows us to simplify the architecture quite a bit, and do some other things in the process:

  • migrate dependency and script management to poetry
  • add pre-commit hooks for linting and formatting
  • remove celery, and associated code
  • decouple scanning logic from database logic as much as possible

@LeoMcA
migrate to poetry and upgrade deps
481706d
@LeoMcA
missed upgrading beautifulsoup4
5a65663
@LeoMcA
remove no-longer used celery config from website
627d658 
re-order docker-compose file to group related services
@LeoMcA
add pre-commit
0cf8f01
@LeoMcA
run pre-commit against all files
3764134
@LeoMcA
add black formatter
a35d4a1
@LeoMcA
format all files with black
1583d51
@LeoMcA
add isort formatter
e4ae9ab
@LeoMcA
format all files with isort
73b2a81
@LeoMcA
ignore formatting commits in git blame
9d49d48
@LeoMcA
run pre-commit in github action
19e1e9b
@LeoMcA
can't use official pre-commit github action
9eef64c
@LeoMcA
remove unnecessary files post-poetry migration
09e3282
@LeoMcA
remove separate scanner instance
dee6d25 
remove celery and related dependencies
run scan synchronously in api request
@LeoMcA
move valid_hostname func into website module
4dd6034
@LeoMcA
remove scanning logic from database.insert_test_results
3d6096f
@LeoMcA
remove database calls from scanner.tasks.scan
11098e9
@LeoMcA
remove unused files
d733972
@LeoMcA
remove unused config variables
af3aa27
@LeoMcA
reduce imports from scanner in database, remove unused database funct…
605fcf7 
…ions
@LeoMcA
move states out of scanner
2a5cfea
@LeoMcA
merge scanner.local.scan into scanner.tasks.scan
fa4e83f
@LeoMcA
move scanner.tasks.scan to scanner.scan
eeb938e
@LeoMcA
update README, add httpobs-local-scan script to poetry
f9c3b6d
@LeoMcA
add script to run flask and document in README
875c228
@LeoMcA
don't save exception in db/send in response
848bba4
@LeoMcA
run all tests, add to README, update test_retriever
64d748b
@LeoMcA
cache poetry and pre-commit in github action
fd7557d
@LeoMcA
fix: fail fast if attempting to validate empty hostname
66b200b
@LeoMcA
update contribute.json
46bb16a
@LeoMcA LeoMcA requested a review from fiji-flo January 16, 2024 13:38
fiji-flo
fiji-flo approved these changes Jan 16, 2024
View reviewed changes
Copy link

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice stream of atomic commits. Looks great. Didn't catch anything suspicious.

@LeoMcA LeoMcA merged commit 3adb1c5 into master Jan 17, 2024
2 checks passed
@LeoMcA
Copy link
Contributor Author

LeoMcA commented Jan 17, 2024

Amazing, thank you! 🚀

@LeoMcA LeoMcA deleted the next branch January 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeoMcA @fiji-flo