This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
chore(nsp): ignore warning about redos for date parsing in moment #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
.nsprc
Outdated
| @@ -2,6 +2,8 @@ | |||
| "exceptions": [ | |||
| // i18n-abide@0.0.25 | |||
| "https://nodesecurity.io/advisories/39", | |||
| "https://nodesecurity.io/advisories/48" | |||
| "https://nodesecurity.io/advisories/48", | |||
| // moment@2.19.2 | |||
There was a problem hiding this comment.
nit: 2 too many spaces. Fix that and ship it!
shane-tomlinson
approved these changes
Nov 28, 2017
There was a problem hiding this comment.
@philbooth - can you remove the extra 2 spaces and ship it!
philbooth
force-pushed
the
phil/ignore-nsp-error
branch
from
c421364
to
82577eb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to moment/moment#4163.
@mozilla/fxa-devs r?