Upgrade urllib3 to 1.25.6 to fix #8078 #8079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.25 now verifies HTTPS connections by default https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification
jgmize
changed the title
|
This failed on CircleCI with the following:
This is due to psf/requests#5067 which was fixed by psf/requests#5092 so upgrading requests to 2.22.0 should resolve this issue. |
alexgibson
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version 1.25 now verifies HTTPS connections by default
https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification
Issue / Bugzilla link
#8078