Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding positionOffset in the schema of the anchor component #16

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ybinstock
Copy link

I added positionOffset in the schema of the anchor component to offset models that don't have a pivot point at the bottom.

For our organization, the models are being placed too far down and we thought others might have a similar problem or want to have access to the position from the XR anchor.

I introduced positionOffset into the schema and adding it to the positionVec3 for the setAttribute Position method.

blairmacintyre and others added 3 commits April 19, 2018 11:19
update for latest app and polyfill
… models that don't have a pivot point at the bottom
@blairmacintyre
Copy link
Contributor

can you submit this against the develop branch, please. We're doing dev there, and then shifting things to the master branch when we do an npm release.

@blairmacintyre
Copy link
Contributor

And, have you tested this against the new version that supports vertical planes? I'm usually leery of pulling a position out of a composite matrix, then adding to it (order of operations, and all that) -- up till now, all the anchors have had y-up, so I'd like to make sure this works when the anchor is on the wall (and thus, y is in the X-Z plane)

@ybinstock ybinstock changed the base branch from master to develop April 25, 2018 14:20
@ybinstock
Copy link
Author

Just changed to develop branch

And no I haven't tested the new version (didn't know there was one, very excited to test vertical planes!)

@blairmacintyre
Copy link
Contributor

sorry, I never got around to doing this and forgot; this still good?

@blairmacintyre
Copy link
Contributor

Just saw an update on this, which reminded me I never dealt with it (sorry). Can you summarize what's changed in the latest commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants