bug-1896962: improve Token admin #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This impproves the Token admin making it effectively like the one in Crash Stats. One nice thing is that tokens are searchable now.
smarnach
approved these changes
May 16, 2024
There was a problem hiding this comment.
I tested this and it works fine. Only minor cosmetic issue is that the column titles are automatically derived from the method names, so the column with the email address is called "Get User Email", which is a bit weird. I added a suggestion with different names, which I tested and confirmed to be working.
Co-authored-by: Sven Marnach <sven@mozilla.com>
Co-authored-by: Sven Marnach <sven@mozilla.com>
Co-authored-by: Sven Marnach <sven@mozilla.com>
|
Thank you! |
|
I didn't realize every suggestion becomes a separate commit. I should probably have made that a single suggestion instead. |
|
You did fine! No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impproves the Token admin making it effectively like the one in Crash Stats. One nice thing is that tokens are searchable now.
To test:
make run