feat: Remove support for BrowserID #1531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
previously requested changes
Apr 10, 2024
| SYNC_TOKENSERVER__DATABASE_URL: mysql://test:test@tokenserver-db:3306/tokenserver | ||
| SYNC_TOKENSERVER__RUN_MIGRATIONS: "true" | ||
| sync-db: | ||
| # Getting sporadic errors in spanner. |
There was a problem hiding this comment.
Do you mean these are happening on CI currently?
There was a problem hiding this comment.
Yep. They are. Apparently the most recent Spanner emulator produces the error I noted. That's why it's locked down to a specific version that does work.
…nto feat/SYNC-3684_browserrip
…nto feat/SYNC-3684_browserrip
mark test only functions as such. I think we can drop MapAndThenTrait for more recent implementations of rust.
…nto feat/SYNC-3684_browserrip
…es/syncstorage-rs into feat/SYNC-3684_browserrip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes BrowserID support from Syncstorage.
In addition it includes several additional elements I needed to perform local testing and validation.
These included:
Testing
Testing is included
Issue(s)
Closes: SYNC-3684