Update: Use Debian bookworm as base docker image #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --secret-keyring option has been silently ignored since GPG v2.1, so it never did anything anyways, and in more recent builds this now generates a console warning. We should simply remove it. This should be fine so long as we are making use of the --homedir option to prevent unexpected changes to the user's GPG keyring.
|
This one has to wait for us to get off CentOS 7 on our VMs. We'll need to plan out what that looks like next week |
jmhodges
reviewed
May 2, 2024
jmhodges
reviewed
May 3, 2024
| @@ -48,7 +48,7 @@ func setRequestStartTime() Middleware { | |||
| } | |||
| } | |||
|
|
|||
| // Run the request through all middlewares | |||
There was a problem hiding this comment.
You know, we could do these gofmt changes out of this PR since we still have wait on the centos7 change. I can post a quick PR.
There was a problem hiding this comment.
I'll rebase my PR after that one lands to remove it - IIRC lint-vet-fmt job will fail without the linting changes. Not that it really matters, but I like keeping the CI green.
jmhodges
added a commit
that referenced
this pull request
May 3, 2024
First seen in PR #898, and maybe worthy of breaking it out to a separate PR. Run with: go1.22.2 fmt ./... go1.22.2 fmt ./tools/... # to catch the submodules
jmhodges
added a commit
that referenced
this pull request
May 3, 2024
First seen in PR #898, and maybe worthy of breaking it out to a separate PR. Run with: go1.22.2 fmt ./... go1.22.2 fmt ./tools/... # to catch the submodules
|
This is patch is shippable once we do the CentOS7 upgrades! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian 10/buster has been discontinued, and stopped receiving security updates as of June 2022, and LTS support is going to expire later this year in June 2024. We should make an effort to upgrade to a newer version of Debian. With that work in mind, I have selected Debian 12/bookworm given that it is the current stable release of Debian.
This PR attempts to upgrade the base docker image from
golang:1.16-bustertodebian:bookworm. This also necessitates an upgrade to golang 1.19, and brings with it a handful of test fixes due to changes in the standard go libraries.This is a subset of PR #893 with only the bits necessary to upgrade the base docker image.