Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update vendored monitor deps #269

Closed
wants to merge 1 commit into from

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Apr 8, 2019

No description provided.

@g-k g-k force-pushed the update-monitor-vendored-deps branch from b2f2f3a to 0e33762 Compare April 8, 2019 21:26
@g-k
Copy link
Contributor Author

g-k commented Apr 8, 2019

in CI getting:

go test -v -covermode=count -count=1 -coverprofile=coverage_monitor.out go.mozilla.org/autograph/tools/autograph-monitor
panic: sql: Register called twice for driver postgres

goroutine 1 [running]:
database/sql.Register(0xeadbb5, 0x8, 0x1092380, 0x1924ae8)
	/usr/local/go/src/database/sql/sql.go:51 +0x1a0
go.mozilla.org/autograph/tools/autograph-monitor/vendor/go.mozilla.org/sops/vendor/github.com/lib/pq.init.0()
	/go/src/go.mozilla.org/autograph/tools/autograph-monitor/vendor/go.mozilla.org/sops/vendor/github.com/lib/pq/conn.go:49 +0x5c
FAIL	go.mozilla.org/autograph/tools/autograph-monitor	0.008s
Makefile:105: recipe for target 'testmonitor' failed

which (per mattes/migrate#322) is due to loading pq twice

@g-k g-k force-pushed the update-monitor-vendored-deps branch from 0e33762 to 3a96a6c Compare April 9, 2019 11:42
@g-k g-k closed this Apr 24, 2019
@g-k g-k deleted the update-monitor-vendored-deps branch April 24, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant