Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-9055 - Allow toolbar button to be displayed highlighted #20191

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented May 10, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

  • This PR adds isSelectedOnTap Bool property for elements that need to remain selected after they are tapped.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner May 10, 2024 13:39
@@ -11,6 +11,9 @@ public struct ToolbarElement {
/// Whether the toolbar element can be interacted with
let isEnabled: Bool

/// Indicates if element is selected on tap
let isSelectedOnTap: Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be shouldDisplayAsHighlighted and the button should be displayed with the highlighted color even for the normal button state if true. So we should also not toggle if the button is selected or not.

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented May 13, 2024

Warnings
⚠️ Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️ Variable 'cross' in Medium is out of alphabetical order.
Messages
📖 Edited 2 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 9253a6c

@PARAIPAN9 PARAIPAN9 merged commit 96a478a into mozilla-mobile:main May 13, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants