Add FXIOS-9056 - Add configuration to toolbar button to render text inside image #20184
Conversation
|
Please use latest changes in main to have your PR running. Thanks! |
…olbar-button-to-render-text-inside-image
Generated by 🚫 Danger Swift against 90794a6 |
| // MARK: - UX Constants | ||
| struct UX { | ||
| static let cornerRadius: CGFloat = 2 | ||
| static let titleFont = UIFont.boldSystemFont(ofSize: 11) |
There was a problem hiding this comment.
We should use FXFontStyles here.
|
|
||
| // Tab count related constants | ||
| static let defaultCountLabelText = "0" | ||
| static let maxTabCountToShowInfinity = 100 |
There was a problem hiding this comment.
According to the logic later in code the last number displayed is 99. I suggest to change the constant here and adjust the logic accordingly.
|
This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏 |
…olbar-button-to-render-text-inside-image
| @@ -101,6 +101,7 @@ public struct StandardImageIdentifiers { | |||
| public static let subtract = "subtractLarge" | |||
| public static let sync = "syncLarge" | |||
| public static let syncTabs = "syncTabsLarge" | |||
| public static let tabNumber = "tabNumberLarge" | |||
There was a problem hiding this comment.
Where is this image coming from? The Acorn icon library doesn't have an image named this way. Only images found in Acorn should be added to StandardImageIdentifiers. Please use tab instead.
There was a problem hiding this comment.
I hadn't found it, so I took it from the Client.
PARAIPAN9
deleted the
sparaipan/fxios-9056-Add-configuration-to-toolbar-button-to-render-text-inside-image
branch
📜 Tickets
Jira ticket
Github issue
💡 Description
TabNumberButtonclass, responsible for displaying the number of open tabs. Currently in draft status because the animation has not yet been added.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)