Add FXIOS-9027 Integrate address toolbar in Client #20142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient # Conflicts: # firefox-ios/Client/Frontend/Browser/BrowserViewController/Actions/GeneralBrowserAction.swift # firefox-ios/Client/Frontend/Browser/BrowserViewController/State/BrowserViewControllerState.swift # firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
…lient # Conflicts: # firefox-ios/Client/Frontend/Browser/BrowserViewController/State/BrowserViewControllerState.swift
Ramiz69
suggested changes
May 5, 2024
| case tap | ||
| case longPress | ||
| } | ||
|
|
||
| class ToolbarButton: UIButton, ThemeApplicable { |
| case goToHomepage | ||
| } | ||
|
|
||
| class GeneralBrowserMiddlewareAction: Action { |
| setupLayout() | ||
| } | ||
|
|
||
| required init?(coder: NSCoder) { |
| import Redux | ||
| import UIKit | ||
|
|
||
| class NavigationToolbarContainer: UIView, ThemeApplicable, StoreSubscriber { |
firefox-ios/Client/Frontend/Browser/Toolbars/NavigationToolbarContainer.swift
Show resolved
Hide resolved
| case didLoadToolbars | ||
| } | ||
|
|
||
| class ToolbarMiddlewareAction: Action { |
| import Redux | ||
| import ToolbarKit | ||
|
|
||
| class ToolbarAction: Action { |
firefox-ios/Client/Frontend/Browser/Toolbars/Redux/ToolbarMiddleware.swift
Outdated
Show resolved
Hide resolved
| import Redux | ||
| import ToolbarKit | ||
|
|
||
| class ToolbarMiddleware: FeatureFlaggable { |
There was a problem hiding this comment.
you should use final everywhere where it is needed, since you forcefully enable static dispatching and you or other developers immediately understand that this object has no child and do not have to worry about the fact that your edits may break something somewhere else in code
There was a problem hiding this comment.
Thanks for your comment. We only use final in rare cases in our project when we want to indicate that this class should not be subclassed. In most cases adding final is therefor not necessary.
|
This pull request has conflicts when rebasing. Could you fix it @thatswinnie? 🙏 |
PARAIPAN9
reviewed
May 10, 2024
...tend/Browser/BrowserViewController/Extensions/BrowserViewController+TabToolbarDelegate.swift
Outdated
Show resolved
Hide resolved
…lient # Conflicts: # firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift # firefox-ios/nimbus.fml.yaml
…ate-address-toolbar-in-client
thatswinnie
had a problem deploying
to
github-pages
GitHub Actions
Failure
OrlaM
approved these changes
May 13, 2024
…ate-address-toolbar-in-client
Client.app: Coverage: 31.11
Generated by 🚫 Danger Swift against 6b32cba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This integrates the navigation toolbar with dummy buttons - only the home button works so far.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)