Add FXIOS-8988 [Microsurvey] Redux architecture #20094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
force-pushed
the
cc/FXIOS-8988_setup-redux-for-prompt
branch
from
41adb49
to
aa8cdb6
Compare
cyndichin
commented
Apr 30, 2024
cyndichin
commented
Apr 30, 2024
Comment on lines
-36
to
-46
| init(_ appState: BrowserViewControllerState) { | ||
| self.init( | ||
| windowUUID: appState.windowUUID, | ||
| isOpen: appState.fakespotState.isOpen, | ||
| sidebarOpenForiPadLandscape: appState.fakespotState.sidebarOpenForiPadLandscape, | ||
| currentTabUUID: appState.fakespotState.currentTabUUID, | ||
| expandState: appState.fakespotState.expandState, | ||
| telemetryState: appState.fakespotState.telemetryState | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
I am able to build without this, seems like we can remove
Client.app: Coverage: 31.14
Generated by 🚫 Danger Swift against b19f69c |
OrlaM
approved these changes
May 7, 2024
cyndichin
force-pushed
the
cc/FXIOS-8988_setup-redux-for-prompt
branch
from
aa8cdb6
to
d4c613d
Compare
|
This pull request has conflicts when rebasing. Could you fix it @cyndichin? 🙏 |
cyndichin
force-pushed
the
cc/FXIOS-8988_setup-redux-for-prompt
branch
3 times, most recently
from
664e6c3
to
8f68fdd
Compare
cyndichin
commented
May 13, 2024
firefox-ios/Client/Frontend/Microsurvey/Redux/MicrosurveyState.swift
Outdated
Show resolved
Hide resolved
cyndichin
commented
May 13, 2024
firefox-ios/Client/Frontend/Microsurvey/Redux/MicrosurveyMiddleware.swift
Outdated
Show resolved
Hide resolved
cyndichin
force-pushed
the
cc/FXIOS-8988_setup-redux-for-prompt
branch
from
b01b44b
to
98f3898
Compare
cyndichin
force-pushed
the
cc/FXIOS-8988_setup-redux-for-prompt
branch
from
98f3898
to
b218ade
Compare
cyndichin
changed the title
OrlaM
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Setup Redux architecture to handle state for microsurvey prompt. Draft PR to discuss with Orla in how we envision our architecture to be going forward and to see microsurveys as an example.
Handles
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)