Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9042 - Add optional badge to ToolbarElement/ToolbarButton #20071

Merged
merged 14 commits into from May 22, 2024
Merged

Add FXIOS-9042 - Add optional badge to ToolbarElement/ToolbarButton #20071

merged 14 commits into from May 22, 2024

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Apr 30, 2024 •
edited

📜 Tickets

Jira ticket
Github issue

💡 Description

Example

demo

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner April 30, 2024 08:26
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Apr 30, 2024 •
edited

Warnings
⚠️ Variable 'crossCircleFill' in Medium is out of alphabetical order.
⚠️ Variable 'cross' in Medium is out of alphabetical order.
Messages
📖 Edited 3 files
📖 Created 2 files

Generated by 🚫 Danger Swift against 9aa4ea6

thatswinnie
thatswinnie reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@thatswinnie thatswinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon should have a background as otherwise the icon underneath shines through.
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-03 at 10 18 31

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request has conflicts when rebasing. Could you fix it @PARAIPAN9? 🙏

thatswinnie
thatswinnie reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@thatswinnie thatswinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon privateModeCircleFillMediumPurple needs to be updated in Client as well.

Karma197617
Karma197617 reviewed May 22, 2024
View reviewed changes
Copy link

@Karma197617 Karma197617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is left for me to do

@thatswinnie
Copy link
Contributor

What is left for me to do

Nothing on this PR, @Karma197617. If you'd like to contribute you could look for issues here and please make sure to read through our contributing wiki article 🙏

@PARAIPAN9 PARAIPAN9 merged commit 9a98991 into main May 22, 2024
11 of 13 checks passed
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-9042-Add-optional-badge-to-ToolbarElement branch May 22, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karma197617 Karma197617 Karma197617 left review comments

@thatswinnie thatswinnie thatswinnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PARAIPAN9 @mobiletest-ci-bot @thatswinnie @Karma197617