Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-8815 [SwiftLint] control_statement #19895

Closed

Conversation

cavaevinci
Copy link
Contributor

馃摐 Tickets

Jira ticket
Github issue

馃挕 Description

Implemented control_statement swiftlint rule

馃摑 Checklist

You have to check all boxes before merging

  • [鉁旓笍] Filled in the above information (tickets numbers and description of your work)
  • [鉁旓笍] Updated the PR name to follow our PR naming guidelines
  • [鉁旓笍] Wrote unit tests and/or ensured the tests suite is passing
  • [鉁旓笍] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • [鉁旓笍] If needed, I updated documentation / comments for complex code and public methods
  • [鉁旓笍] If needed, added a backport comment (example @Mergifyio backport release/v120)

@cavaevinci cavaevinci requested a review from a team as a code owner April 19, 2024 15:44
Copy link
Contributor

mergify bot commented Apr 20, 2024

This pull request has conflicts when rebasing. Could you fix it @cavaevinci? 馃檹

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cavaevinci seems like there are conflicts to be resolved, but otherwise looks great!

Copy link
Contributor

github-actions bot commented May 7, 2024

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

@github-actions github-actions bot added the stale Stalebot use this label to stale issues and PRs label May 7, 2024
@github-actions github-actions bot closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stalebot use this label to stale issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants