Add FXIOS-19805 [Fonts] Update: Fonts related to Accessory view to use FXFontStyles #19881
+4
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
reviewed
Apr 19, 2024
There was a problem hiding this comment.
thanks for all the work on helping us standardizing our fonts @NeoKolian! Code looks great, but notice there are some font adjustments. Could you provide before and after screenshots for @cwzilla to validate?
cyndichin
changed the title
cyndichin
changed the title
|
Hi @NeoKolian! Here is some feedback from our designer. Can you make these font adjustments in this PR? Thank you in advance!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
fonts in following classes updated:
AccessoryViewProvider
TPAccessoryInfo
AutofillAccessoryViewButtonItem
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)