Refactor FXIOS-8970 [Fonts] LoginDetail to use FXFontStyles

[NeoKolian]

📜 Tickets

Jira ticket
Github issue

💡 Description

fonts in following classes updated: LoginDetailTableViewCell,
LoginDetailCenteredTableViewCell.
TextStyling parameters was updated to match password font requirements.

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[NeoKolian]

before:

[NeoKolian]

after:

[adudenamedruby]

Looks like you've got a Swiftlint failure. :(

[cyndichin]

as per @cwzilla's suggestion, lets update this to use subheadline

[cyndichin]

as per @cwzilla's suggestion, lets update this to use subheadline

[cyndichin]

thanks @NeoKolian, the updates look great! a couple of changes request due to design reviewing and would like to adjust the font size.

[NeoKolian]

Looks like you've got a Swiftlint failure. :(

Hmm, strange, it seems like somebody fix it. After SwiftLint --fix I found only next issues that not related to my code

[adudenamedruby]

I'm not sure if xcode is not picking this up, but you'll have to fix this manually, if swiftlint --fix doesn't do it, or the pipeline won't be able to run. :( Lemme know if I can help.

[NeoKolian]

I'm not sure if xcode is not picking this up, but you'll have to fix this manually, if swiftlint --fix doesn't do it, or the pipeline won't be able to run. :( Lemme know if I can help.

Thank you, now it's done

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 32.67%
📖	Edited 3 files
📖	Created 0 files

Client.app: Coverage: 31.28

File	Coverage
LoginDetailCenteredTableViewCell.swift	0.0%	⚠️
LoginDetailTableViewCell.swift	0.0%	⚠️

Generated by 🚫 Danger Swift against a0037e5

[NeoKolian]

thanks @NeoKolian, the updates look great! a couple of changes request due to design reviewing and would like to adjust the font size.

Hello @cyndichin! Please check if all requirements are done

[isabelrios]

Bitrise is red because there is a UI test failing 3 out of 3: testCreateLoginManually() this test may require some changes after this PR so that it is green. Please let us know if you need help

[cyndichin]

thanks @NeoKolian, the updates look great! a couple of changes request due to design reviewing and would like to adjust the font size.

Hello @cyndichin! Please check if all requirements are done

@NeoKolian thank you! could you provide the updated screenshots for @cwzilla to verify? Also, in terms of the test errors, can you rebase this branch so its up to date with main?

@isabelrios these tests seem to be failing locally for me in main as well. It seems these tests are also failing in the artifacts but passes on the check in bitrise for some reason.

[cwzilla]

Hi @cyndichin, the new mono font looks good! However, is it possible to make some changes to the input labels and regular text input (non-password).

For the input label, could we use Subhead and for text input, body. Here's a Figma reference - please refer to the first one. Thanks!

[cyndichin]

thanks @cwzilla! @NeoKolian could you make those additional changes to the font types? thank you!