Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly handle engineOrders and defaultEngines records for search-config-v2 (bug 1879515). #169

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: Correctly handle engineOrders and defaultEngines records for search-config-v2 (bug 1879515). #169

merged 1 commit into from
May 22, 2024

Conversation

Standard8
Copy link
Collaborator

No description provided.

@Standard8 Standard8 requested a review from mandysGit May 8, 2024 17:07
mandysGit
mandysGit approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@mandysGit mandysGit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me.
The only change needed is removing the extra line from package.json.
r+ after that fix.

package.json Outdated Show resolved Hide resolved
@Standard8 Standard8 merged commit bf52440 into mozilla-extensions:main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandysGit mandysGit mandysGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Standard8 @mandysGit