[WIP] Fix and complete server-side JID validation and escaping. #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lo, I'll review it asap! |
|
Hi,
Thanks a lo, I'll review it asap!
You've added a dependency, is it OK regarding the packages (like the Debian one?).
For Debian, I will of course take care of that. For everything else, it has
to be - no JID validation is possible without that (except with copying the
code, of course).
|
edhelas
reviewed
May 24, 2019
That was a bad idea as it breaks full-text search in posts, as every normal word is a valid JID. This reverts commit b35249b.
|
I updated a lot, please review again, @edhelas ☺! |
Natureshadow
changed the title
No need to explode all over the place.
Natureshadow
force-pushed
the
jid-validation
branch
from
d977b50
to
54083b7
Compare
The previous code could lead to data from different users being handled for the wrong UI element. For example, from the view of this code, the JIDs "foo-bar@example.com", "foo_bar@example.com", "foo.bar@example.com", which are all distinct and valid JIds, were handled as one and the same.
Previously, the use of - and _ for sufficēs was mixed, sometimes even for the same names, and the elements were only matche due to the old, non-unique cleanupId code turning _ into -.
|
As I'm not planning to maintain a specifical stringprep dependency from that I'm assuming that the only proper way to do so would be to directly call "idn" (http://www.gnu.org/software/libidn/manual/html_node/Invoking-idn.html) and call it from PHP. I'm already using it during the registration process (see https://api.movim.eu/accounts/register) and it has a complete Nodeprep implementation. |
|
Let's see if I can revive this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.