Ride Sharing #192
Draft
Ride Sharing #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixguendling
force-pushed
the
ridesharing
branch
7 times, most recently
from
84e9144
to
b025374
Compare
felixguendling
force-pushed
the
ridesharing
branch
from
b025374
to
d73bbb6
Compare
* wip * wip
pablohoch
reviewed
Jan 21, 2022
| @@ -314,13 +323,43 @@ void add_direct_connections(std::vector<journey>& journeys, | |||
| transport.duration_ = d.duration_; | |||
| transport.mumo_accessibility_ = d.accessibility_; | |||
| transport.mumo_type_ = to_string(d.type_); | |||
| transport.is_walk_ = true; | |||
There was a problem hiding this comment.
Doppelt, wird ein paar Zeilen drüber schon gesetzt
pablohoch
reviewed
Jan 21, 2022
Comment on lines
341
to
353
| } else { | ||
| auto const dep_time = | ||
| fwd ? q_start.time_ | ||
| : static_cast<std::time_t>(q_start.time_ - d.duration_ * 60); | ||
| auto const arr_time = | ||
| fwd ? static_cast<std::time_t>(q_start.time_ + d.duration_ * 60) | ||
| : q_start.time_; | ||
| j.stops_.front().departure_.timestamp_ = | ||
| dep_time; // reference start invalid by now | ||
| j.stops_.front().departure_.schedule_timestamp_ = dep_time; | ||
| dest.arrival_.timestamp_ = arr_time; | ||
| dest.arrival_.schedule_timestamp_ = arr_time; | ||
| } |
There was a problem hiding this comment.
Wird auch oben vor dem if-Block schon gesetzt.
felixguendling
force-pushed
the
ridesharing
branch
from
c80fd56
to
c034278
Compare
felixguendling
force-pushed
the
ridesharing
branch
from
7c579ce
to
8c7d5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.