Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 nullsafety #7

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

2.0.0 nullsafety #7

wants to merge 39 commits into from

Conversation

moseskarunia
Copy link
Owner

@moseskarunia moseskarunia commented Mar 5, 2021

[2.0.0-nullsafety.9] - 25 March 2021

  • Fix: CornerstoneSnapshot age should always be positive if timestamp is same / before current time.

[2.0.0-nullsafety.8] - 24 March 2021

  • Update: LocallyPersistentRepositoryMixin load is now accept a nullable Object as param. This to make it possible for adding parameter when loading locally. (Need to be overridden manually)

[2.0.0-nullsafety.7] - 8 March 2021

  • Update: Make Failure in CornerstonePersistentRepositoryMixin becomes Failure<Object>.

[2.0.0-nullsafety.6] - 8 March 2021

  • Fix: UseCase's call param now is correctly marked as required.

[2.0.0-nullsafety.5] - 8 March 2021

  • New: ConvertCornerstoneExceptionToFailure, a common implementation of ConvertToFailure.

[2.0.0-nullsafety.4] - 8 March 2021

  • Update: ConvertToFailure's call is now accepts Object instead of dynamic. The return is also changed from Failure<dynamic> to Failure<Object>. This change have 2 goals: To further enforce null-safety and because logically, it makes no sense to call ConvertToFailure with null parameter.

[2.0.0-nullsafety.3] - 6 March 2021

  • Update: Abstract classes' parameters are now required. A named param marked with required can still have its implementation accept default value instead of required. On the other hand, a non required param cannot be implemented with required. Therefore, for flexibility, all abstract classes' named parameters are now required. See example's people_data_source for more info.

[2.0.0-nullsafety.2] - 5 March 2021

  • Update: Bump hive dependency to 2.0.0.

[2.0.0-nullsafety.1] - 4 March 2021

  • New: Null-safety! To use, update your dart version to >=2.12.0, or use flutter 2.0.0
  • Update: [CornerstonePersistentRepositoryMixin] If load is called on empty storage, will return a nicer Failure.

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #7 (7eed1f6) into master (24fbb39) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           32        36    +4     
=========================================
+ Hits            32        36    +4     
Impacted Files Coverage Δ
lib/src/core/cornerstone_exception.dart 100.00% <100.00%> (ø)
lib/src/core/failure.dart 100.00% <100.00%> (ø)
lib/src/core/repository.dart 100.00% <100.00%> (ø)
...ties/convert_cornerstone_exception_to_failure.dart 100.00% <100.00%> (ø)
...ities/cornerstone_persistent_repository_mixin.dart 100.00% <100.00%> (ø)
lib/src/utilities/cornerstone_snapshot.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fbb39...7eed1f6. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #7 (3dd8e9c) into master (24fbb39) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           32        36    +4     
=========================================
+ Hits            32        36    +4     
Impacted Files Coverage Δ
lib/src/core/cornerstone_exception.dart 100.00% <100.00%> (ø)
lib/src/core/failure.dart 100.00% <100.00%> (ø)
lib/src/core/repository.dart 100.00% <100.00%> (ø)
...ties/convert_cornerstone_exception_to_failure.dart 100.00% <100.00%> (ø)
...ities/cornerstone_persistent_repository_mixin.dart 100.00% <100.00%> (ø)
lib/src/utilities/cornerstone_snapshot.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24fbb39...3dd8e9c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants