Fix linting in examples folder

[thinkcache]

Issue #136

[thinkcache]

Current issues:

pylint -j 8 --recursive=y mosec examples
************* Module distil_bert_server_pytorch
examples/distil_bert_server_pytorch.py:66:12: E1101: Module 'torch' has no 'device' member (no-member)
examples/distil_bert_server_pytorch.py:66:67: E1101: Module 'torch' has no 'device' member (no-member)
examples/distil_bert_server_pytorch.py:81:19: E1101: Module 'torch' has no 'tensor' member; maybe 'Tensor'? (no-member)
************* Module resnet50_server_pytorch
examples/resnet50_server_pytorch.py:50:18: E1101: Module 'cv2' has no 'imdecode' member (no-member)
examples/resnet50_server_pytorch.py:50:36: E1101: Module 'cv2' has no 'IMREAD_COLOR' member (no-member)
examples/resnet50_server_pytorch.py:56:14: E1101: Module 'cv2' has no 'resize' member (no-member)
examples/resnet50_server_pytorch.py:72:12: E1101: Module 'torch' has no 'device' member (no-member)
examples/resnet50_server_pytorch.py:72:67: E1101: Module 'torch' has no 'device' member (no-member)
examples/resnet50_server_pytorch.py:87:20: E1101: Module 'torch' has no 'stack' member (no-member)
examples/resnet50_server_pytorch.py:87:33: E1101: Module 'torch' has no 'tensor' member; maybe 'Tensor'? (no-member)
examples/resnet50_server_pytorch.py:89:19: E1101: Module 'torch' has no 'argmax' member (no-member)

------------------------------------------------------------------
Your code has been rated at 9.24/10 (previous run: 9.27/10, -0.03)

make: *** [lint] Error 2

A possible solution as per pytorch/pytorch#701
This creates another error.

pylint -j 8 --recursive=y mosec examples
************* Module mosec.worker
mosec/worker.py:64:0: R0022: Useless option value for 'disable', 'no-self-use' was moved to an optional extension, see https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)
************* Module mosec.server
mosec/server.py:306:4: R0913: Too many arguments (6/5) (too-many-arguments)

------------------------------------------------------------------
Your code has been rated at 9.97/10 (previous run: 9.24/10, +0.73)

make: *** [lint] Error 8

any help is appreciated.

[kemingy]

Should we use pylint --disable=import-error examples? Or maybe we should place these examples in another repo?

• there may be lots of other 3rd libraries required in the examples, it will cost lots of time to prepare the environment to run the lint
• those import errors are not very helpful

@lkevinzc What do you think?

[lkevinzc]

Should we use pylint --disable=import-error examples? Or maybe we should place these examples in another repo?

• there may be lots of other 3rd libraries required in the examples, it will cost lots of time to prepare the environment to run the lint
• those import errors are not very helpful

@lkevinzc What do you think?

How about locally we do lint for all codes including those under examples, but we do not do that in CI? Local dev environment should have those third parties installed. Doing full lint for examples benefits code styles.

[kemingy]

How about locally we do lint for all codes including those under examples, but we do not do that in CI? Local dev environment should have those third parties installed. Doing full lint for examples benefits code styles.

I think we can ignore the import errors in this PR. It's better to have a CI to make sure all the examples can run with the latest code. We can track this in another issue.

[lkevinzc]

I think we can ignore the import errors in this PR. It's better to have a CI to make sure all the examples can run with the latest code. We can track this in another issue.

LGTM.

[kemingy]

Hi @thinkcache, can try this Makefile to ignore the import errors.

[kemingy]

@thinkcache For the lint error in mosec/, I cannot reproduce this one. Which pylint version are you using now? I'm using 2.14.4. It should be able to read the config from pyproject.toml file.

[thinkcache]

Latest run:

pylint -j 8 --recursive=y --disable=import-error examples --generated-members=numpy.*,torch.*,cv2.*,cv.*

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

ref: pytorch/pytorch#701

@kemingy please review.

[kemingy]

That's weird. I can pass all the lint locally. How come it doesn't have consistent results?

From the CI results, it seems reasonable. But I guess it's also okay to ignore R,C for the examples.

What do you think? @lkevinzc

pylint -j 8 --recursive=y --disable=R,C,import-error examples --generated-members=numpy.*,torch.*,cv2.*,cv.*

[lkevinzc]

That's weird. I can pass all the lint locally. How come it doesn't have consistent results?

From the CI results, it seems reasonable. But I guess it's also okay to ignore R,C for the examples.

What do you think? @lkevinzc

pylint -j 8 --recursive=y --disable=R,C,import-error examples --generated-members=numpy.*,torch.*,cv2.*,cv.*

Figured out that CI got error messages because the py environment does not install mosec dev package. I tested locally and found if I pip uninstall mosec I can reproduce the error; but the error disappears after I pip install -e .

[lkevinzc]

Figured out that CI got error messages because the py environment does not install mosec dev package. I tested locally and found if I pip uninstall mosec I can reproduce the error; but the error disappears after I pip install -e .

@thinkcache Could you help to add one line pip install -e . in the Makefile's lint (just put it at the first line) to fix the CI errors pls? Thanks!

[thinkcache]

@lkevinzc
changes added. Can you trigger the CI build to test if this worked?