Add automated testing for foyer tutorial notebooks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when breaking API changes occured to the MoSDeF tools, a lot of our notebooks would break silently. Without automated testing, this can be quite difficult to keep track of, and it is not uncommon for these notebooks to quickly fall out of sync with the current updates. This PR introduces a GitHub Action to create a conda environment, and use the pytest plugin `nbval` to run tests on each notebook. This will occur daily, for pushes and pull requests.
jennyfothergill
approved these changes
Jun 15, 2021
|
Also, maybe we should pin some versions in our environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when breaking API changes occurred to the MoSDeF tools, a lot
of our notebooks would break silently.
Without automated testing, this can be quite difficult to keep track of,
and it is not uncommon for these notebooks to quickly fall out of sync
with the current updates.
This PR introduces a GitHub Action to create a conda environment, and
use the pytest plugin
nbvalto run tests on each notebook. This willoccur daily, for pushes and pull requests.