Add a property for each LoggerDestination to Logger #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Sep 28, 2023
composer/loggers/logger.py
Outdated
Comment on lines
150
to
159
| def _get_logger_destination(self, logger_type) -> Optional[Union[LoggerDestination, Sequence[LoggerDestination]]]: | ||
| """Returns instances of the specified logger destination, if it/they exist.""" | ||
| # Check every time just in case user appended to destinations list later. | ||
| logger_destinations = [destination for destination in self.destinations if isinstance(destination, logger_type)] | ||
| if len(logger_destinations) == 1: | ||
| return logger_destinations[0] | ||
| elif len(logger_destinations) > 1: | ||
| return logger_destinations | ||
| else: # length is 0 | ||
| return None |
There was a problem hiding this comment.
Can we type all of the functions so it's easy for users?
Also, I'm not sure i love its sometimes list and sometimes not because end user then always has to check for both scenarios. Can we say it always returns a list? Because usually I just want to apply operation to all logger destinations of that type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds a property decorator for each loggerdestination, so a user can easily get a loggerdestination by just calling
mlflow_logger = trainer.logger.mlflowfor example