Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labels #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add aria-labels #48

wants to merge 1 commit into from

Conversation

judygab
Copy link

@judygab judygab commented Jun 7, 2019

This pull request is related to 645 When I ran accessibility test on AutoSuggest I received issues that the combobox and input fields don't have descriptions. To fix these issues I added aria-labels which are optional and the users can pass the values of it through props. This would also fix (#485 ), (#283 ), (#642 ). Aria labels will pe passed down from react-autosuggest.

@iroy2000
Copy link

iroy2000 commented Nov 6, 2019

@FabienDeshayes / @judygab why this is not merged ?

@aberezkin
Copy link
Collaborator

aberezkin commented May 11, 2020

You can do this using inputProps/containerProps, can't you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants